refactor: convert blueprints to typescript #4306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leon
reviewed
Feb 1, 2017
| description: '', | ||
|
|
||
| availableOptions: [ | ||
| { name: 'spec', type: Boolean } | ||
| ], | ||
|
|
||
| normalizeEntityName: function (entityName) { | ||
| var parsedPath = dynamicPathParser(this.project, entityName.split('.')[0]); | ||
| normalizeEntityName: function (entityName: string) { |
There was a problem hiding this comment.
You shorten it even more by writing methods directly in the object
export default Blueprint.extend({
normalizeEntityName(entityName: string) {
...
}
})There was a problem hiding this comment.
There will be a second pass to add more type information and cleanup the code.
The goal here was to convert with minimal changes to reduce the chance of conflicts with other active PRs.
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.