Skip to content

feat(component): use a relative path for the component blueprints #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Apr 12, 2016

No description provided.

directives: [],
pipes: []
templateUrl: '<%= dasherizedModuleName %>.html',
styleUrls: ['<%= dasherizedModuleName %>.css']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will relative paths work here? How will the web server find the files?
Will they be compiled as part of the component during build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angular itself uses the moduleId to build the path for templates and styles. SystemJS adds the __moduleName to the compiled files. It works.

@Brocco
Copy link
Contributor

Brocco commented Apr 18, 2016

This same fix/change was merged in with PR #427

Code is here

Closing this PR.

@Brocco Brocco closed this Apr 18, 2016
@hansl hansl deleted the moduleName branch May 3, 2016 20:44
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants