Skip to content

fix (#4199): let postcss pass-through sourcemap #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

asnowwolf
Copy link

resolve issue #4199 CSS Sourcemap is empty.

@filipesilva
Copy link
Contributor

@asnowwolf I think this was fixed in #4222. If that's incorrect, let me know.

@asnowwolf
Copy link
Author

asnowwolf commented Jan 27, 2017

@filipesilva I think the root cause is post-css-loader lost the sourcemap which generated by sass-loader. I'm not sure that PR is resolved the issue. I'll test it later.

@asnowwolf
Copy link
Author

asnowwolf commented Jan 27, 2017

@filipesilva
I just tested the latest master branch and it still lost the sourcemap (I turned on the sourcemap options)

@filipesilva filipesilva reopened this Jan 27, 2017
@filipesilva
Copy link
Contributor

Can you give me some repro steps to see that? I added a few tests in #4222 and they verify mappings are being generated.

@asnowwolf
Copy link
Author

asnowwolf commented Jan 27, 2017

see https://github.com/asnowwolf/t1

the step is:

  1. pull the latest master branch of angular-cli
  2. npm link it as global package
  3. ng new t1 --style=scss --extract-css
  4. npm i --save [email protected]
  5. add @import '~bootstrap/scss/bootstrap'; to style.scss
  6. ng serve --souremap
  7. in chrome, I can't see the sourcemap correctly.

@asnowwolf
Copy link
Author

asnowwolf commented Jan 27, 2017

Sorry, I've tested it again, It's right now. I think there are some mistakes on my first test.

@asnowwolf asnowwolf closed this Jan 27, 2017
@filipesilva
Copy link
Contributor

I was just testing myself and your demo seemed to give me the sourcemaps. I think you didn't npm link angular-cli to have the master version in the project.

Anyway, glad it's working for you!

@asnowwolf
Copy link
Author

Sure, I think that's the mistake. thank you.

@asnowwolf asnowwolf deleted the pass-through-sourcemap branch February 3, 2017 06:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants