Skip to content

chore: update dependencies in ng2 blueprint #4151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: update dependencies in ng2 blueprint #4151

wants to merge 1 commit into from

Conversation

beeman
Copy link
Contributor

@beeman beeman commented Jan 21, 2017

All package are updated to the latest version, except:

  • protractor, as version 5 is not supported on Node 4
  • typescript, as version 2.1 is not compatible with @angular/compiler-cli

filipesilva
filipesilva suggested changes Jan 21, 2017
View reviewed changes
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes please, would like to see if it makes the deps more consistent while still correct.

packages/angular-cli/blueprints/ng2/files/package.json Outdated
"@types/node": "^6.0.42",
"@angular/compiler-cli": "^2.4.4",
"@types/jasmine": "2.5.41",
"@types/node": "^7.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to keep this one on 6, as it's LTS but 7 isn't yet.

packages/angular-cli/blueprints/ng2/files/package.json Outdated
"ts-node": "1.2.1",
"tslint": "^4.3.0",
"ts-node": "2.0.0",
"tslint": "^4.3.1",
"typescript": "~2.0.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do TS ~2.0.10?

packages/angular-cli/blueprints/ng2/files/package.json Outdated
"ts-helpers": "^1.1.1",
"zone.js": "^0.7.2"
"rxjs": "^5.0.3",
"zone.js": "^0.7.6"
},
"devDependencies": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make all devDeps except @angular/compiler-cli use ~?

@filipesilva filipesilva requested a review from hansl January 21, 2017 16:40
@filipesilva
Copy link
Contributor

@hansl are there any deps we shouldn't update on new projects aside from TS and protractor?

@beeman beeman force-pushed the update-package-deps branch from 6ecf2d1 to de3880d Compare January 21, 2017 16:46
@beeman beeman force-pushed the update-package-deps branch 2 times, most recently from 13ad2c6 to 988c6b9 Compare February 7, 2017 00:38
@beeman beeman force-pushed the update-package-deps branch from 988c6b9 to 1bbb7d5 Compare February 7, 2017 05:37
@beeman
Copy link
Contributor Author

beeman commented Feb 7, 2017

@hansl the failing build was caused by a breaking change in jasmine-spec-reporter:

jasmine-spec-reporter module exports SpecReporter and DisplayProcessor, see SpecReporter and DisplayProcessor usages.

https://github.com/bcaudan/jasmine-spec-reporter/releases/tag/v3.0.0

filipesilva
filipesilva approved these changes Feb 14, 2017
View reviewed changes
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beeman can you rebase?

asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@beeman
build: update dependencies in ng2 blueprint
dce0394 
Close angular#4151
@beeman beeman deleted the update-package-deps branch May 2, 2018 03:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hansl hansl hansl approved these changes

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beeman @filipesilva @hansl @googlebot