refactor(mobile): remove unused mobile code #4143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM if tests are still passing. Good work! |
|
There was an unused dep but that was all. Kinda surprised myself. |
The mobile flag hasn't worked for a while. When/if it is added again, it's code would need to be done from scratch since the CLI has undergone a lot of changes since it last worked and was tested. Fix angular#4141
filipesilva
force-pushed
the
remove-mobile-code
branch
from
2249095 to
5875a5d
Compare
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
The mobile flag hasn't worked for a while. When/if it is added again, it's code would need to be done from scratch since the CLI has undergone a lot of changes since it last worked and was tested. Fix angular#4141
|
@filipesilva , May I ask, did I get it right? This PR remove the --mobile from CLI? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mobile flag hasn't worked for a while.
When/if it is added again, it's code would need to be done from scratch since the CLI has undergone a lot of changes since it last worked and was tested.
Fix #4141