-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(@ngtools/webpack): fix error #4078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the quick response @hansl! I'd love to be able to run master with this fix, but it doesn't appear to be functional atm. |
Yes, thank you @hansl for the quick fix! This error drove me insane today. Looking forward to this being available on npm. |
@hansl, I've just installed version 1.0.0-rc.1 and created a test project wtih
Here's the output for
And here's the output for
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When calling
getText()
it's important to use theSourceFile
, otherwise in some cases the node doesn't have an internal SourceFile property and TypeScript throws an error.Also moved the acceptance test to be a Jasmine spec in @ngtools/webpack. This is faster and I made it more accurate (rather than mocking everything).
Fix #4072