WIP: Add angular-cli.json option to explicitly specify entryModule when …

[tsabirgaliev]

…it can’t be inferred from code

In some cases @ngtools/webpack is unable to resolve the application entry module automatically.
This commit exposes entryModule option of AotPlugin in angular-cli.json so that you can specify it by hand.

[tsabirgaliev]

Please @hansl @filipesilva can you point me in right direction with appveyor failure? can't reproduce it on my machine :(

[tsabirgaliev]

And also please suggest a proper place and way to cover the changes with tests

[filipesilva]

@hansl is the appropriate person to review this PR.

Meanwhile though, can you provide a test case that would break without this enhancement?

Regarding appveyor, I think it was having some trouble a bit ago. It shouldn't be relevant to your PR atm.

[tsabirgaliev]

@filipesilva I have the following test case, just can't figure out how and where to properly incorporate it into the test suite:

if (someCondition) {
  platformBrowserDynamic().bootstrapModule(AppModule, { providers }).catch((reason) => {
    console.error(reason);
  });
} else {
  platformBrowserDynamic().bootstrapModule(AppModule).catch((reason) => {
    console.error(reason);
  });
}

I know this is somewhat contrived example, it is just to show the static resolver is not 100% bulletproof.
Probably, this can be further reduced to a minimal case, that breaks resolution, I just don't know enough internals to do it.

[tsabirgaliev]

#2887 (comment) -- the workaround suggested in this comment also breaks resolution

[hansl]

This is a use case we need to fix, rather than work around. I'll take a look at it.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}