Skip to content

chore(help): remove ng help false errors #4001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

CarreraPHP
Copy link
Contributor

chore(help): remove false errors show in ng help for files that are not
meant to be cli command yet co-exist in the same path as run files

@filipesilva
Copy link
Contributor

Thank you for this fix, but I think a more complete one already went in (#3982). Correct me if I'm wrong though.

@CarreraPHP
Copy link
Contributor Author

@filipesilva , I agree with you. Actually #3982 was submitted first and when going through the code i found a exception list in it. So I though of submit based on it. As part of open source, we all want to contribute to the projects that we are dependent on. I am just trying to find Issues that i can submit PR but most of the time i end up submitting a duplicate one even for the issues that i report. I am waiting for Plugin Architecture to be implemented, hope it arrives soon.

@CarreraPHP CarreraPHP deleted the ng-help-bug branch February 9, 2017 14:30
@filipesilva
Copy link
Contributor

Yeah I completely get that, and your help is much appreciated. Many of the fixes and enhancements that go in are completely driven by the community. Sometimes PRs fall through the cracks (like this one) and something else ends up being merged before. I'm sorry for that :/

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants