-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(docs): replace outdated routes note #3983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
- We include the `@angular/router` NPM package when creating or initializing a project. | ||
|
||
- When you generate a route, we provide a `--routing` option to create a placeholder route configuration file, which can be called like `ng g module my-module --routing`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you generate a route
-> When you generate a module
This PR replaces the docs about routing in README, so that instead of suggesting it's not possible, it talks about the `--routes` generation instead.
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@googlebot the extra commit is just a merge from master to allow bring this PR up to date. |
This PR replaces the docs about routing in README, so that instead of suggesting it's not possible, it talks about the `--routes` generation instead.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR replaces the docs about routing in README, so that instead of suggesting it's not possible, it talks about the
--routes
generation instead.