Skip to content

fix(docs): replace outdated routes note #3983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2017
Merged

Conversation

Meligy
Copy link
Contributor

@Meligy Meligy commented Jan 13, 2017

This PR replaces the docs about routing in README, so that instead of suggesting it's not possible, it talks about the --routes generation instead.


- We include the `@angular/router` NPM package when creating or initializing a project.

- When you generate a route, we provide a `--routing` option to create a placeholder route configuration file, which can be called like `ng g module my-module --routing`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you generate a route -> When you generate a module

This PR replaces the docs about routing in README, so that instead of suggesting it's not possible, it talks about the `--routes` generation instead.
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@filipesilva
Copy link
Contributor

@googlebot the extra commit is just a merge from master to allow bring this PR up to date.

@filipesilva filipesilva merged commit 2677138 into angular:master Jan 18, 2017
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
This PR replaces the docs about routing in README, so that instead of suggesting it's not possible, it talks about the `--routes` generation instead.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants