Skip to content

Fix GitHub typo Git'h'ub to Git'H'ub. #3935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 12, 2017
Merged

Fix GitHub typo Git'h'ub to Git'H'ub. #3935

merged 4 commits into from
Jan 12, 2017

Conversation

potato4d
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@potato4d
Copy link
Contributor Author

I signed it.

@googlebot
Copy link

CLAs look good, thanks!

@equinox
Copy link
Contributor

equinox commented Jan 10, 2017

It's here, also. Throughout the different READMEs there are "github", "Github" etc might be worth making them all "GitHub" in the one pr at some point

@potato4d
Copy link
Contributor Author

potato4d commented Jan 10, 2017

OK, I'll try it.

@potato4d
Copy link
Contributor Author

I have completed fix it.
Changes are document only, source code is not done because it may be destructive(e.g. /packages/angular-cli/commands/github-pages-deploy.ts)

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@hansl
Copy link
Contributor

hansl commented Jan 12, 2017

Ignoring the CLA bot because the original author signed it (see comments above), and I'm a Google employee.

@hansl hansl added cla: yes and removed cla: no labels Jan 12, 2017
@hansl
Copy link
Contributor

hansl commented Jan 12, 2017

LGTM, thanks!

@hansl hansl merged commit b3ef6a4 into angular:master Jan 12, 2017
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
@potato4d potato4d deleted the fix-github-typo branch September 11, 2019 21:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants