Skip to content

Updating misleading build target documentation #3915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2017
Merged

Updating misleading build target documentation #3915

merged 2 commits into from
Jan 9, 2017

Conversation

RicardoVaranda
Copy link
Contributor

The old build documentation stated that prod was a valid target command which is incorrect.

The working and valid production commands are:

--prod
-prod

Not:
prod

Copy link

@tcoz tcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the docs it seems there's all these options:

ng build --prod
(seems preferred)

ng build -prod
(works, albeit frowned upon)

ng build --target -prod
(what this doc says)

If that's correct, maybe that could be made clearer elsewhere, otherwise this fixes the --target arg doc.

@RicardoVaranda
Copy link
Contributor Author

@tcoz Thank you for your fast reply and feedback, I've made some changes to further clarify this hopefully this makes it more clear.

Copy link

@tcoz tcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RicardoVaranda RicardoVaranda changed the title Updating incorrect target option Updating misleading build target documentation Jan 9, 2017
@hansl
Copy link
Contributor

hansl commented Jan 9, 2017

LGTM. Thanks!

@hansl hansl merged commit cc23e80 into angular:master Jan 9, 2017
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants