Skip to content

WIP:refactor(serve): cleanup command options #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

WIP:refactor(serve): cleanup command options #3910

wants to merge 1 commit into from

Conversation

clydin
Copy link
Member

@clydin clydin commented Jan 9, 2017

Removes unused command options for serve in addition to some minor general cleanup of the command.

WIP: should be rebased if/when #3952 is merged which implements relevant live-reload options.

@hansl
Copy link
Contributor

hansl commented Jan 9, 2017

Rather than remove the options, can we not make them work? It seems to me people would like to control ports, even if those options are a bit obscure.

@hansl hansl self-requested a review January 9, 2017 19:53
@clydin
Copy link
Member Author

clydin commented Jan 9, 2017

@hansl I saw PR #3381 which allows full configurability of the inline client URL which would make the live reload port/host options redundant (even more so considering it's most likely a more obscure option).
Personally, I prefer the more structured individual host/port options but i'm unsure if there are use cases that require the more free-form option from the mentioned PR.

@clydin clydin changed the title refactor(serve): cleanup command options WIP:refactor(serve): cleanup command options Jan 11, 2017
@clydin
Copy link
Member Author

clydin commented Jan 11, 2017

created a PR that implements the relevant live reload options: #3952

@hansl
Copy link
Contributor

hansl commented Jan 12, 2017

@clydin Should this PR be closed considering the other 2 PRs?

@clydin clydin closed this Jan 12, 2017
@clydin clydin deleted the serve-command branch January 12, 2017 20:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants