docs(readme): add node 4 as a prerequisite #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cli generates the project properly with older node versions but angular-cli-github-pages needs node v4 so ng serve fails on older node versions. Make this dependency explicit so that people aren't confused. Closes angular#38
|
+1 |
|
@IgorMinar I don't see how the test would fail since this is a docs change only. Must be something else going on? |
|
@jimthedev the build was broken in a previous commit. Don't worry about it. |
|
@cironunes ok cool. thanks |
|
thanks for the pr |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cli generates the project properly with older node versions but angular-cli-github-pages needs
node v4 so ng serve fails on older node versions. Make this dependency explicit so that people
aren't confused.
Closes #38