-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(build): fix path error when appConfig has no main #3867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7e20b51
to
444a2e5
Compare
From what I understand this also allows people to use the CLI for apps that have no main at all, correct? |
@hansl yes, it will simply compile |
scripts: ['./script.js'] | ||
}] | ||
}), | ||
})) | ||
.then(() => ng('build')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you verify that console.log('hello')
is in the output? Alternatively, does ng serve
still work? I'd rather test that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
f5251e3
to
ec0a1df
Compare
ec0a1df
to
d07dbcb
Compare
LGTM. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes a path error when
main
is missing inangular-cli.json
: