Skip to content

feat(deploy): add github pages deploy #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2016
Merged

feat(deploy): add github pages deploy #366

merged 1 commit into from
Apr 8, 2016

Conversation

filipesilva
Copy link
Contributor

This PR adds (and improves upon) the functionality previously in https://github.com/IgorMinar/angular-cli-github-pages directly to the CLI.

Later, this functionality will be split into an addon of it's own again, but for now it is better to keep it in the same codebase for rapid development.

@filipesilva filipesilva force-pushed the gh-pages-deploy branch 2 times, most recently from e10a411 to 9977e26 Compare March 31, 2016 18:44
hansl
hansl reviewed Mar 31, 2016
View reviewed changes
addon/ng2/commands/github-pages-deploy.ts
import * as win from 'ember-cli/lib/utilities/windows-admin';
import * as CreateGithubRepo from '../tasks/create-github-repo'

// import * as https from 'https';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove commented code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh.. my bad. Done.

@hansl
Copy link
Contributor

hansl commented Mar 31, 2016

For testing, verify if you can monkey patch exec like this: require('child_process').exec = function(x, callback) { /*...*/; callback(); }. That should make it possible to bypass everything in the shell.

jkuri
jkuri reviewed Mar 31, 2016
View reviewed changes
package.json
@@ -40,6 +40,7 @@
"ember-cli": "2.4.2",
"exit": "^0.1.2",
"fs-extra": "^0.26.6",
"inquirer": "^0.10.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inquirer comes with ember-cli, we don't need another package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you can use it as return this.ui.prompt({ ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not know that! Using it now.

@filipesilva filipesilva force-pushed the gh-pages-deploy branch 4 times, most recently from 1625317 to 9a4636d Compare April 4, 2016 10:24
@filipesilva
Copy link
Contributor Author

Fixed the issues pointed out in the comments, looking at tests now.

@hansl
Copy link
Contributor

hansl commented Apr 5, 2016

@filipesilva: ping. What's the status about testing this?

@filipesilva
Copy link
Contributor Author

@hansl been working on tests yesterday and today. Expect to have a good few tests by the end of tomorrow.

Was a bit tricky since I had to stub exec but also provide it with a list of command/response pairs (including error'd ones) for each test. This is because the results determine the path the command/task code will take.

I plan to put this out as a helper for other tests to use.

@filipesilva filipesilva mentioned this pull request Apr 6, 2016
Closed
@filipesilva
Copy link
Contributor Author

@hansl tests are in.

@filipesilva filipesilva force-pushed the gh-pages-deploy branch 2 times, most recently from 6b29d29 to 13d9c91 Compare April 7, 2016 01:01
filipesilva
filipesilva reviewed Apr 7, 2016
View reviewed changes
README.md
@@ -201,15 +210,6 @@ This will use the `lint`/`format` npm script that in generated projects uses `ts

You can modify the these scripts in `package.json` to run whatever tool you prefer.


### Formatting code
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda piggybacking on this PR tbh... but I noticed this is outdated as the previous section covers it. Can put it on a different PR if needed.

@filipesilva filipesilva force-pushed the gh-pages-deploy branch 2 times, most recently from fa94de0 to 69dd00d Compare April 7, 2016 17:35
@hansl
Copy link
Contributor

hansl commented Apr 8, 2016

LGTM.

@filipesilva filipesilva merged commit 331f0cf into angular:master Apr 8, 2016
@filipesilva filipesilva deleted the gh-pages-deploy branch June 13, 2016 16:13
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipesilva @hansl @jkuri