Skip to content

fix(doc): removed hanging comma in code example and fixed gramma #3585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2016

Conversation

davidcraddock
Copy link

@davidcraddock davidcraddock commented Dec 16, 2016

There was a hanging comma in the app data example. Leaving it in would result in a tslint error in the real world. Added a fix for the wording of the last sentence in the document.

There was a hanging comma in the app data example.  Leaving it in would
result in a tslint error in the real world.
Codebacca and others added 2 commits December 16, 2016 11:16
@davidcraddock davidcraddock changed the title fix(doc): removed hanging comma in code example fix(doc): removed hanging comma in code example and fixed gramma Dec 16, 2016
@hansl hansl self-requested a review December 16, 2016 21:50
@hansl
Copy link
Contributor

hansl commented Dec 16, 2016

LGTM. Thanks!

@hansl hansl merged commit 7545d51 into angular:master Dec 16, 2016
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants