Skip to content

module prefix #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

nweldev
Copy link
Contributor

@nweldev nweldev commented Dec 14, 2016

issue #3452
depend on #3457

still work to do :

  • some unit tests on generate directive and generate component
  • use the ${prefix}-root selector when generating a new module and his main component

use ``ng g c foo --prefix='bar'`` or ``ng g d foo --prefix='bar'`` in order to use
another prefix than the one defined by default in angular-cli.json apps[0].prefix
tslint rules "directive-selector" and "component-selector" can accept any array of prefix,
and is therefore compatible with this approach
this is a temporary solution pending angular#3452 closure
…ectives prefix

This is not the final commit ! We still need to find an agreement on which solution
to use between exported constants and comments, then, if the first one is choosed,
move the associated code to utilities (see TODOs) and make the associated UTs.

see angular#3452
getConstConfig permit to get an exported const string value from a module.ts file

see angular#3452
when set, --prefix=foo will add a ``export const ModulePrefix = 'foo';`` to the
.module.ts file

see angular#3452
@sumitarora
Copy link
Contributor

@noelmace Please rebase branch with latest code.

@hansl
Copy link
Contributor

hansl commented Sep 27, 2017

Closing every Blueprints related issue and PR.

@hansl hansl closed this Sep 27, 2017
@nweldev nweldev deleted the feature/3452-module-prefix branch April 9, 2018 11:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants