[feat]partially upgrade dependencies #3515
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Hi. Please rebase; we updated a bunch of other dependencies already. I'll review once this PR is up to date. |
|
@hansl it's rebased now. |
|
Seems like this PR is a mess now. The changes to validate_dependencies are weird and the sync-deps doesn't seem to work... |
|
My mistake! @hansl sorry, what i want is to check the dependencies version across the packages in this repo. Perhaps i should not exit with 1, a warning it's better. Do you think it's reasonable? What's the weird part you are talking about? |
e-cloud
force-pushed
the
update-deps
branch
3 times, most recently
from
72687c3 to
d665f83
Compare
|
@hansl please have a review :). |
|
@e-cloud fix conflicts please |
|
conflicts resolved and I don't upgrade the yarn.lock @hansl |
e-cloud
force-pushed
the
update-deps
branch
3 times, most recently
from
fe88671 to
cdfbbb8
Compare
|
@hansl Would you give some time to review this? or just let it be? You can close this PR if not your desire. |
e-cloud
force-pushed
the
update-deps
branch
3 times, most recently
from
22191c8 to
c820f83
Compare
1. All upgraded dependencies involve no code changes 2. `dependencies` of repo's `package.json` is the join of packages' dependencies
and increase the timeout for computer with low io rate
adjust eslint config, and adjust some code to fit the style.
and fix related dependencies
not upgrading to v1.2 is because it require extra config file. That should be determine by the maintainer.
|
@hansl request for review |
|
will split the PR into two |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The PR upgrade some of dependencies that doesn't need big code changes, and provide a script for better dependencies management.
Fix #3504