Skip to content

chore(formatting): correction for package.json #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2016
Merged

chore(formatting): correction for package.json #346

merged 1 commit into from
Mar 25, 2016

Conversation

zackarychapple
Copy link
Contributor

chore(formatting): correction for package.json

realized a change snuck in on the package.json that disables the tests command from running tests

@zackarychapple zackarychapple changed the title chore(formatting): updating travis to run eslint, and correction for package.json chore(formatting): correction for package.json Mar 25, 2016
@filipesilva
Copy link
Contributor

lgtm get this in :D

@hansl
Copy link
Contributor

hansl commented Mar 25, 2016

Oh shoot totally missed that. You should have a separate lint script instead, please.

@Brocco
Copy link
Contributor

Brocco commented Mar 25, 2016

Definitely get this in, npm test should run tests 😇

@zackarychapple
Copy link
Contributor Author

Updated to run tests and lint separately per @hansl

@filipesilva
Copy link
Contributor

looks good

@hansl
Copy link
Contributor

hansl commented Mar 25, 2016

LGTM

@zackarychapple zackarychapple merged commit 5da51b0 into angular:master Mar 25, 2016
@zackarychapple zackarychapple deleted the travis-eslint branch March 25, 2016 03:39
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants