Skip to content

feat(build production): introduce the production build #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2016
Merged

feat(build production): introduce the production build #329

merged 1 commit into from
Apr 4, 2016

Conversation

cironunes
Copy link
Member

For production build:

  • removed live reload references (still not 100%)
  • stopped copying tests and .ts files + tsconfig.json

Missing:

Closes #41

@cironunes
Copy link
Member Author

I'm not sure if this is the best approach. I was trying to create the build command and extend the ember-cli, but I got stuck at some point and just decided to deliver something so you guys can give feedback.

/cc @angular/angular-cli-team

@hansl
Copy link
Contributor

hansl commented Mar 21, 2016

Looks good but Angular2App was changed significantly this weekend

@cironunes
Copy link
Member Author

I'll update it accordingly today.

@cironunes cironunes force-pushed the feature/production-build branch 2 times, most recently from e50f8e8 to 7febeb3 Compare March 24, 2016 21:09
@hansl
Copy link
Contributor

hansl commented Mar 24, 2016

Cool. LGTM :)

We'll need to improve a LOT but this is a good first step.

@cironunes cironunes force-pushed the feature/production-build branch 6 times, most recently from 4cd01e1 to 5f37828 Compare March 27, 2016 20:17
@hansl
Copy link
Contributor

hansl commented Mar 29, 2016

You'll have to rebase again. We're getting closer though. I can help with the rest :)

@cironunes
Copy link
Member Author

I'll do that soon :)

@cironunes cironunes force-pushed the feature/production-build branch from 5f37828 to 85fd073 Compare April 2, 2016 22:08
hansl
hansl reviewed Apr 3, 2016
View reviewed changes
lib/broccoli/angular2-app.js
@method _getDotfilesTree
@return {Tree} The dotfiles exclusion tree.
*/
Angular2App.prototype._getDotfilesTree = function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this is more _getPublicTree.

@hansl
Copy link
Contributor

hansl commented Apr 3, 2016

Very good. A few nits. Could you also squash your commits into 1?

I think this is very close to being done.

@cironunes cironunes force-pushed the feature/production-build branch from 85fd073 to a058996 Compare April 3, 2016 22:23
@hansl
Copy link
Contributor

hansl commented Apr 3, 2016

LGTM.

@cironunes cironunes merged commit a058996 into angular:master Apr 4, 2016
@cironunes cironunes deleted the feature/production-build branch April 7, 2016 13:03
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@hansl hansl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Production build
2 participants
@cironunes @hansl