chore(e2e): chdir back to the previous dir at the end of a test. #3287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
force-pushed
the
e2e-chdir-back
branch
from
6834e84 to
f810c35
Compare
Meligy
suggested changes
Nov 27, 2016
| @@ -6,8 +6,6 @@ import {expectFileSizeToBeUnder} from '../../../utils/fs'; | |||
|
|
|||
|
|
|||
| export default function(argv: any, skipCleaning: () => void) { | |||
| const currentDir = process.cwd(); | |||
There was a problem hiding this comment.
This is needed, because the file uses this variable to switch directories after that (or maybe change https://github.com/angular/angular-cli/pull/3287/files#diff-826d2a48a6d98e1c11c9d7014d637925L27 (scroll up a bit after clicking so you can see the highlighted line) to read from env variables).
|
The travis is green, had to cancel it that's why it appears red. Travis seems to be having some problems. |
Brocco
approved these changes
Nov 30, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.