Skip to content

chore(protractor): update protractor to ~4.0.13 #3244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2016

Conversation

cnishina
Copy link
Contributor

@cnishina cnishina commented Nov 23, 2016

package.json

  • Removed Protractor. npm test does not appear to be using Protractor.

packages/angular-cli/blueprints/ng2/files/package.json

  • Update to protractor 4.0.13. see changelog
  • Remove webdriver-manager as a dependency. Protractor includes
    webdriver-manager as a dependency.
  • Since packages/angular-cli/blueprints/ng2/files/protractor.conf.js uses
    directConnect with chrome, the pree2e step does not need to download
    the selenium standalone server or gecko driver.

updated Travis

@cnishina
Copy link
Contributor Author

😦 chromium does not play well with the latest chromedriver. changing the title to WIP

@cnishina cnishina changed the title chore(protractor): update protractor to ~4.0.11 WIP chore(protractor): update protractor to ~4.0.11 Nov 23, 2016
@hansl
Copy link
Contributor

hansl commented Nov 23, 2016

Just tag me when you're ready for a review, I'll change the labels and do it :)

@cnishina cnishina force-pushed the update_protractor branch 2 times, most recently from 228e714 to af2277d Compare December 5, 2016 22:14
@hansl
Copy link
Contributor

hansl commented Dec 5, 2016

Travis was green (we're low on resources so I killed it before it finished the optional tests). Let me know if this is still Work In Progress or if it's ready for a review.

@cnishina cnishina force-pushed the update_protractor branch 2 times, most recently from 38c906c to 18c680f Compare December 8, 2016 01:07
@cnishina cnishina changed the title WIP chore(protractor): update protractor to ~4.0.11 WIP chore(protractor): update protractor to ~4.0.12 Dec 8, 2016
@cnishina cnishina force-pushed the update_protractor branch 2 times, most recently from a78dafd to e22a6ce Compare December 9, 2016 05:31
@cnishina cnishina changed the title WIP chore(protractor): update protractor to ~4.0.12 WIP chore(protractor): update protractor to ~4.0.13 Dec 9, 2016
@cnishina cnishina force-pushed the update_protractor branch 2 times, most recently from 76a5e32 to 8300f03 Compare December 9, 2016 20:01
@cnishina cnishina changed the title WIP chore(protractor): update protractor to ~4.0.13 chore(protractor): update protractor to ~4.0.13 Dec 9, 2016
@cnishina
Copy link
Contributor Author

cnishina commented Dec 9, 2016

Ran locally

./bin/ng new tmp
cd tmp
ng serve &
ng e2e

console output:

  • only downloads chromedriver
  • the initial test passes
❯ ng e2e                                                                                           ⏎

> [email protected] pree2e /Users/cnishina/src/angular-cli/tmp
> webdriver-manager update --standalone false --gecko false

[13:23:02] I/update - chromedriver: file exists /Users/cnishina/src/angular-cli/tmp/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.25mac64.zip
[13:23:02] I/update - chromedriver: unzipping chromedriver_2.25mac64.zip
[13:23:03] I/update - chromedriver: setting permissions to 0755 for /Users/cnishina/src/angular-cli/tmp/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.25
[13:23:03] I/update - chromedriver: v2.25 up to date

> [email protected] e2e /Users/cnishina/src/angular-cli/tmp
> protractor "./protractor.conf.js"

[13:23:03] I/direct - Using ChromeDriver directly...
[13:23:03] I/launcher - Running 1 instances of WebDriver
Spec started

  tmp App
    ✓ should display message saying app works

Executed 1 of 1 spec SUCCESS in 1 sec.
[13:23:05] I/launcher - 0 instance(s) of WebDriver still running
[13:23:05] I/launcher - chrome #01 passed

All end-to-end tests pass.

package.json
- Removed Protractor. `npm test` does not appear to be using Protractor.
- Chromedriver 2.25 does not work well with Chromium, use Chrome.

packages/angular-cli/blueprints/ng2/files/package.json
- Update to protractor 4.0.13. see [changelog](https://github.com/angular/protractor/blob/master/CHANGELOG.md)
- Remove webdriver-manager as a dependency.  Protractor includes
  webdriver-manager as a dependency.
- Since packages/angular-cli/blueprints/ng2/files/protractor.conf.js uses
  directConnect with chrome, the pree2e step does not need to download
  the selenium standalone server or gecko driver.
@hansl
Copy link
Contributor

hansl commented Dec 9, 2016

LGTM, thanks!

@hansl hansl merged commit 3d6122a into angular:master Dec 9, 2016
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants