-
Notifications
You must be signed in to change notification settings - Fork 12k
chore(protractor): update protractor to ~4.0.13 #3244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
😦 chromium does not play well with the latest chromedriver. changing the title to WIP |
Just tag me when you're ready for a review, I'll change the labels and do it :) |
228e714
to
af2277d
Compare
Travis was green (we're low on resources so I killed it before it finished the optional tests). Let me know if this is still Work In Progress or if it's ready for a review. |
38c906c
to
18c680f
Compare
a78dafd
to
e22a6ce
Compare
76a5e32
to
8300f03
Compare
Ran locally
console output:
|
package.json - Removed Protractor. `npm test` does not appear to be using Protractor. - Chromedriver 2.25 does not work well with Chromium, use Chrome. packages/angular-cli/blueprints/ng2/files/package.json - Update to protractor 4.0.13. see [changelog](https://github.com/angular/protractor/blob/master/CHANGELOG.md) - Remove webdriver-manager as a dependency. Protractor includes webdriver-manager as a dependency. - Since packages/angular-cli/blueprints/ng2/files/protractor.conf.js uses directConnect with chrome, the pree2e step does not need to download the selenium standalone server or gecko driver.
- will squash if this works
8300f03
to
abae90d
Compare
LGTM, thanks! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
package.json
npm test
does not appear to be using Protractor.packages/angular-cli/blueprints/ng2/files/package.json
webdriver-manager as a dependency.
directConnect with chrome, the pree2e step does not need to download
the selenium standalone server or gecko driver.
updated Travis