chore(contributing): update the javascript style guide url #3171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the javascript style guide url from googlecode to github
filipesilva
suggested changes
Nov 22, 2016
There was a problem hiding this comment.
The link you added also has a warning saying it moved to https://google.github.io/styleguide/jsguide.html. Can you change it to that?
update the javascript style guide url from javascriptguide.xml to jsguide.html
|
@filipesilva, I have updated the URL & merged branch regularly. However, I don't know if something is pending from my side. |
|
Sorry for the delay @CarreraPHP no, there is nothing pending from your side. Will merge today. |
filipesilva
approved these changes
Dec 8, 2016
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
update the javascript style guide url from googlecode to github Fix angular#3153 Close angular#3171
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the javascript style guide url from googlecode to github
Fix #3153