Skip to content

docs(readme): update ng --help to ng help in readme #3159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

docs(readme): update ng --help to ng help in readme #3159

wants to merge 1 commit into from

Conversation

kevcha
Copy link

@kevcha kevcha commented Nov 16, 2016

screen shot 2016-11-16 at 13 40 39

As you can see above, ng --help doesn't work, we have to use ng help instead, and the command specified in the readme is the wrong one

Fix #3168

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@Meligy
Copy link
Contributor

Meligy commented Nov 17, 2016

Can you please look at the CLA problem in the above comment #3159 (comment) ?

Thanks a lot.

Cheers,

@googlebot
Copy link

CLAs look good, thanks!

@kevcha
Copy link
Author

kevcha commented Nov 17, 2016

Done ! Should I rebase it to master ?

@Meligy
Copy link
Contributor

Meligy commented Nov 17, 2016

That would be nice of you, although possibly not mandatory. Usually the project team merge PRs that are in sync with master, or (apparently) cherry pick commits if the PR is not up date with master.

@kevcha
Copy link
Author

kevcha commented Nov 17, 2016

Done, just hoping that there won't by new commits in master for CI build time :)
Otherwise I'll let the project team cherry-pick the commit !
Thks :)

@filipesilva
Copy link
Contributor

I closed the dupes (thanks @grizzm0!) and we'll get this one merged soon. Thanks all!

@neo
Copy link

neo commented Nov 25, 2016

They generated README.md file should be changed too: #3286 @filipesilva @Meligy

@kevcha
Copy link
Author

kevcha commented Dec 5, 2016

Ah ok, sorry I didn't see that.
So, maybe we can close this PR since #3352 has been merged ?

@grizzm0
Copy link
Contributor

grizzm0 commented Dec 5, 2016

It has not been merged.

This was referenced Dec 5, 2016
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage section in README : ng --help isn't working.
6 participants