fix(build): correctly compile source files against typings #306
Conversation
IgorMinar
force-pushed
the
build-typings
branch
from
e1a27d7 to
55c9638
Compare
| if (this.options && this.options.vendorNpmFiles) { | ||
| vendorNpmFiles = vendorNpmFiles.concat(this.options.vendorNpmFiles); | ||
| } | ||
|
|
||
| var tsConfigCompilerOptions = JSON.parse(fs.readFileSync('src/tsconfig.json', 'utf-8')).compilerOptions; | ||
| // TODO(i): kill rootFilePaths in broccoli-typescript and use tsconfig.json#files instead | ||
| tsConfigCompilerOptions.rootFilePaths = JSON.parse(fs.readFileSync('src/tsconfig.json', 'utf-8')).files; |
There was a problem hiding this comment.
Could you load the json only once?
There was a problem hiding this comment.
ha. yeah. this should really be a separate commit. I missed this change. thanks for pointing it out.
There was a problem hiding this comment.
Note; broccoli-typescript might be going away with the upgrade to broccoli 1.0.
|
Couple of nits, and we still need to talk about typings. |
|
LGTM if you remove the declaration of |
IgorMinar
force-pushed
the
build-typings
branch
2 times, most recently
from
8398d95 to
411a95a
Compare
and document why that it's used only for debugging
It looks like previously we were grabbing typings from outside of the tmp/ directory. If this ever worked, it worked only by accident.
We need to preserve the paths to be the same during build as they are in source repo, so that editor and build pipeline are aligned.
IgorMinar
force-pushed
the
build-typings
branch
from
411a95a to
19774b9
Compare
| @@ -9,10 +9,16 @@ | |||
| "moduleResolution": "node", | |||
| "noEmitOnError": true, | |||
| "noImplicitAny": false, | |||
| "outDir": "../dist/", | |||
| "//outDir": "this option is used only during manual invocation of tsc usually while debugging", | |||
| "outDir": "../dist-manual/", | |||
There was a problem hiding this comment.
Please keep this as ../dist as this is for tooling, more than command line usage of tsc.
There was a problem hiding this comment.
fixed in a follow up commit.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
It looks like previously we were grabbing typings from outside of the tmp/ directory.
If this ever worked, it worked only by accident.