Skip to content

build: fix bazel run invocations of js_binary/js_test #30119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ build --action_env=NG_FORCE_TTY=false
# Required by `rules_ts`.
common --@aspect_rules_ts//ts:skipLibCheck=always
common --@aspect_rules_ts//ts:default_to_tsc_transpiler
# TODO: remove this flag once we get to bazel version >7.
common --incompatible_merge_fixed_and_default_shell_env

# Make TypeScript compilation fast, by keeping a few copies of the compiler
# running as daemons, and cache SourceFile AST's to reduce parse time.
Expand Down Expand Up @@ -156,12 +154,8 @@ build:remote-cache --google_default_credentials
# Additional flags added when running a "trusted build" with additional access
build:trusted-build --remote_upload_local_results=true

###############################
# NodeJS rules settings
# These settings are required for rules_nodejs
###############################

# Fixes use of npm paths with spaces such as some within the puppeteer module
# Fixes issues with browser archives and files with spaces. Could be
# removed in Bazel 8 when Bazel runfiles supports spaces.
build --experimental_inprocess_symlink_creation

####################################################
Expand All @@ -172,6 +166,11 @@ build --experimental_inprocess_symlink_creation
# Prevents the npm package extract from occuring or caching on RBE which overwhelms our quota
build --modify_execution_info=NpmPackageExtract=+no-remote

# Allow the Bazel server to check directory sources for changes. `rules_js` previously
# heavily relied on this, but still uses directory "inputs" in some cases.
# See: https://github.com/aspect-build/rules_js/issues/1408.
startup --host_jvm_args=-DBAZEL_TRACK_SOURCE_DIRECTORIES=1

####################################################
# User bazel configuration
# NOTE: This needs to be the *last* entry in the config.
Expand Down
2 changes: 1 addition & 1 deletion .bazelversion
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6.5.0
7.4.0
5 changes: 5 additions & 0 deletions MODULE.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# TODO(devversion): Investigate bzlmod and use it where possible.

module(
name = "angular_cli",
)
Loading
Loading