chore(test): add --single-run option #2841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
suggested changes
Nov 7, 2016
| @@ -2,5 +2,5 @@ import {ng} from '../../utils/process'; | |||
|
|
|||
|
|
|||
| export default function() { | |||
| return ng('test', '--watch=false'); | |||
| return ng('test', '--single-run'); | |||
There was a problem hiding this comment.
Could we do both here? I want to make sure we don't break --watch=false.
filipesilva
force-pushed
the
allow-single-run
branch
from
d441202 to
68cb6a9
Compare
Doing `ng test --single-run` always worked but outputted a ember-cli warning about a missing option. This PR allows using the option without warning. It's overall better than `--watch=false` because it better aligns with Karma's options. `--watch=false` still works though.
filipesilva
force-pushed
the
allow-single-run
branch
from
68cb6a9 to
70b6038
Compare
|
LGTM. |
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
Doing `ng test --single-run` always worked but outputted a ember-cli warning about a missing option. This PR allows using the option without warning. It's overall better than `--watch=false` because it better aligns with Karma's options. `--watch=false` still works though.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing
ng test --single-runalways worked but outputted a ember-cli warning about a missing option.This PR allows using the option without warning. It's overall better than
--watch=falsebecause it better aligns with Karma's options.--watch=falsestill works though.