Skip to content

bumping to latest typescript for support of string literals in cli pr… #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

bumping to latest typescript for support of string literals in cli pr… #280

wants to merge 2 commits into from

Conversation

zackarychapple
Copy link
Contributor

Current CLI does not support string literals due to angular2 and typescript versions. These version bumps resolve that. Fixes #279

@cironunes
Copy link
Member

@zackarychapple it seems that the PR is non-mergeable, can you check?

@zackarychapple
Copy link
Contributor Author

Checking now.

@zackarychapple
Copy link
Contributor Author

My fork was out of date. I updated it with latest from master

@cironunes
Copy link
Member

Great. Could you also make sure that you squash the commits into one and follow the commit message guidelines?

@zackarychapple
Copy link
Contributor Author

Closing in favor of #282 which was clean from Master

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade TypeScript to 1.8
2 participants