Skip to content

fix(@angular-devkit/build-angular): avoid build performance hit when using custom loader #27120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(@angular-devkit/build-angular): avoid build performance hit when using custom loader #27120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/angular_devkit/build_angular/src/tools/esbuild/application-code-bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,8 @@ export function createBrowserCodeBundleOptions(
}

if (options.externalPackages) {
// Package files affected by a customized loader should not be implicitly marked as external
// Package files affected by a customized plugin should not be implicitly marked as external
if (
options.loaderExtensions ||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is by design, as in some cases loaders need to be configured and applied to node packages.

Copy link
Author

@sod sod Feb 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we stick to webpack I guess, as this made esbuild way slower then what we already have 😢

options.plugins ||
typeof options.externalPackages === 'object'
) {
Expand Down