Skip to content

fix(@angular-devkit/build-angular): normalize asset source locations in Vite-based development server #26556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Dec 1, 2023

The Vite-based development server uses an allow list to permit access to configured assets. This list is checked internally to Vite by using its normalized path form. To ensure that assets provided by the build are checked correctly on all platforms, the asset list is now normalized with Vite's path normalization prior to being used.

@clydin clydin added the target: minor This PR is targeted for the next minor release label Dec 1, 2023
@clydin clydin force-pushed the vite/normalize-asset-sources branch from 612c0d8 to 79413a0 Compare December 1, 2023 19:58
@clydin clydin marked this pull request as ready for review December 1, 2023 19:58
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 1, 2023
@clydin clydin requested a review from alan-agius4 December 1, 2023 20:53
@clydin clydin force-pushed the vite/normalize-asset-sources branch 2 times, most recently from 8f4786e to 849ab46 Compare December 3, 2023 20:15
@clydin clydin requested a review from alan-agius4 December 3, 2023 20:15
@clydin clydin force-pushed the vite/normalize-asset-sources branch from 849ab46 to 4b2a2c2 Compare December 3, 2023 20:45
…in Vite-based development server

The Vite-based development server uses an allow list to permit access to configured assets. This list
is checked internally to Vite by using its normalized path form. To ensure that assets provided by the
build are checked correctly on all platforms, the asset list is now normalized with Vite's path
normalization prior to being used.
@clydin clydin force-pushed the vite/normalize-asset-sources branch from 4b2a2c2 to 1f03692 Compare December 3, 2023 23:26
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 4, 2023
@alan-agius4 alan-agius4 merged commit 9906ab7 into angular:main Dec 4, 2023
@clydin clydin deleted the vite/normalize-asset-sources branch December 4, 2023 12:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants