-
Notifications
You must be signed in to change notification settings - Fork 12k
Use yarn #2652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use yarn #2652
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
This will need to have tests associated to get in. And I want to allow the discussion to continue further in issue #2651 to allow others to weigh in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests as well.
You'll need to modify .travis.yml
, .appveyor.yml
and to find a way to run a new ng new
step.
@@ -1,6 +1,6 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert all changes to this file.
Package name should not change, and the version will be updated via the release process.
The two extra dependencies added are subpackages of this one, and are already added in the appropriate package.json
.
@@ -1,5 +1,6 @@ | |||
import LinkCli from '../tasks/link-cli'; | |||
import NpmInstall from '../tasks/npm-install'; | |||
import Yarn from '../tasks/yarn'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please name task YarnInstall
and file yarn-install
Considering --skip-npm and other possible solutions for running yarn with angular-cli, this PR is not as important as I thought intially. |
Just a note - both Angular 1 & 2 as well as other Angular projects are
switching their dev systems from npm to yarn. I understand we can't require
user projects to do that, though.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is possible implementation for the request in #2651