Skip to content

Use yarn #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Use yarn #2652

wants to merge 7 commits into from

Conversation

adi
Copy link

@adi adi commented Oct 11, 2016

This is possible implementation for the request in #2651

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@adi
Copy link
Author

adi commented Oct 11, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@Brocco
Copy link
Contributor

Brocco commented Oct 13, 2016

This will need to have tests associated to get in. And I want to allow the discussion to continue further in issue #2651 to allow others to weigh in.

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests as well.

You'll need to modify .travis.yml, .appveyor.yml and to find a way to run a new ng new step.

@@ -1,6 +1,6 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes to this file.

Package name should not change, and the version will be updated via the release process.

The two extra dependencies added are subpackages of this one, and are already added in the appropriate package.json.

@@ -1,5 +1,6 @@
import LinkCli from '../tasks/link-cli';
import NpmInstall from '../tasks/npm-install';
import Yarn from '../tasks/yarn';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please name task YarnInstall and file yarn-install

@adi
Copy link
Author

adi commented Nov 29, 2016

Considering --skip-npm and other possible solutions for running yarn with angular-cli, this PR is not as important as I thought intially.

@adi adi closed this Nov 29, 2016
@mgol
Copy link
Member

mgol commented Nov 29, 2016 via email

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants