Skip to content

fix(@angular-devkit/build-angular): ensure all configured assets can be served by dev server #26401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Nov 17, 2023

The Vite-based development server restricts filesystem access by default. However, assets configured by the build option assets are intended to be accessible by the application at runtime. To ensure that these files are accessible, the allow list will now explicitly include all configured assets found during the build.

Closes #26384

@clydin clydin force-pushed the vite/ensure-asset-serving branch 3 times, most recently from 95dba95 to ef69998 Compare November 17, 2023 22:55
…be served by dev server

The Vite-based development server restricts filesystem access by default. However, assets
configured by the build option `assets` are intended to be accessible by the application at
runtime. To ensure that these files are accessible, the allow list will now explicitly include
all configured assets found during the build.
@clydin clydin force-pushed the vite/ensure-asset-serving branch from ef69998 to fb84256 Compare November 20, 2023 16:09
@clydin clydin marked this pull request as ready for review November 21, 2023 15:35
@clydin clydin added the target: minor This PR is targeted for the next minor release label Nov 21, 2023
@clydin clydin requested a review from alan-agius4 November 21, 2023 18:36
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Nov 22, 2023
@clydin clydin merged commit 6473b01 into angular:main Nov 22, 2023
@clydin clydin deleted the vite/ensure-asset-serving branch November 22, 2023 15:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The request url [file path here] is outside of Vite serving allow list.
2 participants