fix(@angular-devkit/build-angular): ensure watch file paths from TypeScript are normalized #26393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Script are normalized The TypeScript compiler converts all paths to use POSIX path separators. When on Windows, this can cause problems when comparing paths from other parts of the build system including the file watching provided by `chokidar`. The referenced files returned from the TypeScript compiler are now normalized to the native path format to mitigate this problem. This also avoids an issue where the same files but with differing path separators were included in the watch files list on Windows due to the bundler using native paths and TypeScript using converted paths.
alan-agius4
approved these changes
Nov 17, 2023
clydin
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeScript compiler converts all paths to use POSIX path separators. When on Windows, this can cause problems when comparing paths from other parts of the build system including the file watching provided by
chokidar. The referenced files returned from the TypeScript compiler are now normalized to the native path format to mitigate this problem. This also avoids an issue where the same files but with differing path separators were included in the watch files list on Windows due to the bundler using native paths and TypeScript using converted paths.