chore(blueprints): update codelyzer #2615
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
approved these changes
Oct 10, 2016
|
Good stuff, thanks! |
|
A final change that I need to introduce as part of this PR are a few templete related rules. I will do that in a few hours today. |
This version includes template support and is compatible with the latest changes in the TemplateParser introduced by Angular 2.0.2. The following new rules are introduced: ``` // Does not allow access to private & protected // in inline templates "templates-use-public": true, // Makes sure `@Injectable()` is invoked and not // used as `@Injectable`. "invoke-injectable": true ``` There's one more rule which verifies if all members accessed in templates are defined in the component's controller but doesn't check the inheritance chain so I'll open a PR for it once we have the entire functionality implemented.
|
Ok, labelling it as WiP. Let me know when finished. |
|
@filipesilva it's ready, I only had to update |
filipesilva
approved these changes
Oct 10, 2016
JJayet
pushed a commit
to JJayet/angular-cli
that referenced
this pull request
Oct 14, 2016
This version includes template support and is compatible with the latest changes in the TemplateParser introduced by Angular 2.0.2. The following new rules are introduced: ``` // Does not allow access to private & protected // in inline templates "templates-use-public": true, // Makes sure `@Injectable()` is invoked and not // used as `@Injectable`. "invoke-injectable": true ``` There's one more rule which verifies if all members accessed in templates are defined in the component's controller but doesn't check the inheritance chain so I'll open a PR for it once we have the entire functionality implemented. Close angular#2615
Brocco
pushed a commit
that referenced
this pull request
Oct 19, 2016
This version includes template support and is compatible with the latest changes in the TemplateParser introduced by Angular 2.0.2. The following new rules are introduced: ``` // Does not allow access to private & protected // in inline templates "templates-use-public": true, // Makes sure `@Injectable()` is invoked and not // used as `@Injectable`. "invoke-injectable": true ``` There's one more rule which verifies if all members accessed in templates are defined in the component's controller but doesn't check the inheritance chain so I'll open a PR for it once we have the entire functionality implemented. Close #2615
texel
pushed a commit
to splice/angular-cli
that referenced
this pull request
Nov 3, 2016
This version includes template support and is compatible with the latest changes in the TemplateParser introduced by Angular 2.0.2. The following new rules are introduced: ``` // Does not allow access to private & protected // in inline templates "templates-use-public": true, // Makes sure `@Injectable()` is invoked and not // used as `@Injectable`. "invoke-injectable": true ``` There's one more rule which verifies if all members accessed in templates are defined in the component's controller but doesn't check the inheritance chain so I'll open a PR for it once we have the entire functionality implemented. Close angular#2615
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version includes template support and is compatible with the latest changes in the
TemplateParserintroduced by Angular 2.0.2.The following new rules are introduced:
There's one more rule which verifies if all members accessed in templates are defined in the component's controller but doesn't check the inheritance chain so I'll open a PR for it once we have the entire functionality implemented.