Skip to content

fix(@angular-devkit/build-angular): clean up internal Angular state during rendering SSR #25927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

alan-agius4
Copy link
Collaborator

This commit clean ups the compiled components state when the build is being executed in watch mode. This is required as otherwise during development Component ID generation collision detected are displayed on the server.

Closes: #25924

@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Sep 29, 2023
…uring rendering SSR

This commit clean ups the compiled components state when the build is being executed in watch mode. This is required as otherwise during development `Component ID generation collision detected` are displayed on the server.

Closes: angular#25924
@alan-agius4 alan-agius4 force-pushed the hmr-server-collision-warn branch from 2df5a03 to 727066c Compare September 29, 2023 11:43
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 29, 2023
Copy link

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 29, 2023
@alan-agius4 alan-agius4 merged commit 2d2e799 into angular:main Sep 29, 2023
@alan-agius4 alan-agius4 deleted the hmr-server-collision-warn branch September 29, 2023 16:47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
2 participants