Skip to content

fix(@angular-devkit/build-angular): watch all bundler provided inputs with esbuild builder #25416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Jun 21, 2023

When using the esbuild-based browser application builder in watch mode (including ng serve), all input files provided by the bundler via the internal metafile information will now be watched and will trigger rebuilds if changed. This allows for files outside of the TypeScript compilation that are also outside of the project source root to be watched. This situation can be encountered in monorepo setups where library code is directly referenced within an application.

… with esbuild builder

When using the esbuild-based browser application builder in watch mode (including `ng serve`),
all input files provided by the bundler via the internal metafile information will now be
watched and will trigger rebuilds if changed. This allows for files outside of the TypeScript
compilation that are also outside of the project source root to be watched. This situation
can be encountered in monorepo setups where library code is directly referenced within an application.
@clydin clydin added the target: patch This PR is targeted for the next patch release label Jun 21, 2023
@clydin clydin marked this pull request as ready for review June 21, 2023 19:07
@clydin clydin linked an issue Jun 21, 2023 that may be closed by this pull request
1 task
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 21, 2023
@clydin clydin requested a review from alan-agius4 June 22, 2023 14:14
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 22, 2023
@clydin clydin merged commit e827c69 into angular:main Jun 22, 2023
@clydin clydin deleted the esbuild/watch-input-files branch June 22, 2023 14:42
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esbuild ng serve not watching html and css files outside project root
2 participants