Skip to content

fix(@angular-devkit/build-angular): support proxy configuration array-form in esbuild builder #25342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

clydin
Copy link
Member

@clydin clydin commented Jun 8, 2023

When using the Webpack-based browser application builder with the development server, the proxy configuration can be in an array form when using the proxyConfig option. This is unfortunately not natively supported by the Vite development server used when building with the esbuild-based browser application builder. However, the array form can be transformed into the object form. This transformation allows for the array form of the proxy configuration to be used by both development server implementations.

@clydin clydin added the target: patch This PR is targeted for the next patch release label Jun 8, 2023
@clydin clydin linked an issue Jun 8, 2023 that may be closed by this pull request
1 task
@clydin clydin force-pushed the esbuild/server-proxy-array-config branch 2 times, most recently from ad2a2d9 to 325b3cf Compare June 8, 2023 20:18
…-form in esbuild builder

When using the Webpack-based browser application builder with the development server, the
proxy configuration can be in an array form when using the `proxyConfig` option. This is unfortunately
not natively supported by the Vite development server used when building with the esbuild-based
browser application builder. However, the array form can be transformed into the object form.
This transformation allows for the array form of the proxy configuration to be used by both
development server implementations.
@clydin clydin force-pushed the esbuild/server-proxy-array-config branch from 325b3cf to e100e2c Compare June 9, 2023 01:36
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 9, 2023
@clydin clydin requested a review from alan-agius4 June 9, 2023 12:00
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 9, 2023
@alan-agius4 alan-agius4 merged commit 779c969 into angular:main Jun 9, 2023
@clydin clydin deleted the esbuild/server-proxy-array-config branch June 9, 2023 13:27
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxyConfig option is not working with esbuild dev server
2 participants