chore(deps): explicitely add @types/node #2528
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2099
We're getting need the
require
typings because ofangular2-template-loader
and are currently getting it transitively via@types/node
inprotractor
.We can't just
declare var require:any
because that would conflict with said@types/node
.Solutions for this are either to add these typings explicitely (this pr), to remove the requirement for
require
inangular2-template-loader
(slated to happen in the future when it's moved to AST) or to manually list used typings intsconfig.json
(which would make the 3rd party lib journey a tad harder).This seems the best solution for now, followed by moving
angular2-template-loader
to AST./cc @hansl