Skip to content

chore(deps): explicitely add @types/node #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Oct 5, 2016

Fix #2099

We're getting need the require typings because of angular2-template-loader and are currently getting it transitively via @types/node in protractor.

We can't just declare var require:any because that would conflict with said @types/node.

Solutions for this are either to add these typings explicitely (this pr), to remove the requirement for require in angular2-template-loader (slated to happen in the future when it's moved to AST) or to manually list used typings in tsconfig.json (which would make the 3rd party lib journey a tad harder).

This seems the best solution for now, followed by moving angular2-template-loader to AST.

/cc @hansl

@posth
Copy link

posth commented Oct 12, 2016

Hi,
Having a very similar problem where the styles.bundle.js generated by the CLI via "ng build" is not yielding a complete styles.bundle.js.

By complete, I mean that we are 2 developers with the same code, same version of Node(6.2.1) and the same AngularCli version (beta17), yet the styles.bundle.js is missing around 300 lines when we compare, more specifically, the:
//Hot Module Repacement sections

And the css base code injcted by the css-loader

JJayet pushed a commit to JJayet/angular-cli that referenced this pull request Oct 14, 2016
@filipesilva filipesilva deleted the add-node-types branch October 14, 2016 18:06
@filipesilva
Copy link
Contributor Author

@posth I don't see how what you mention is related to this PR. Please open a new issue for it.

@posth
Copy link

posth commented Oct 14, 2016

OK thanks for getting back.

Going to dig around on our end first before submitting anything - I believe it is a problem related to our environments more than the CLI itself.

Brocco pushed a commit that referenced this pull request Oct 19, 2016
texel pushed a commit to splice/angular-cli that referenced this pull request Nov 3, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught ReferenceError: require is not defined
4 participants