Skip to content

fix(@angular-devkit/build-angular): set public class fields as properties #24849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2023
Merged

fix(@angular-devkit/build-angular): set public class fields as properties #24849

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bee2dde
fix(@angular-devkit/build-angular): set public class fields as proper…
alan-agius4 Mar 13, 2023
e91935d
fixup! fix(@angular-devkit/build-angular): set public class fields as…
alan-agius4 Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/angular_devkit/build_angular/src/webpack/configs/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,13 @@ export async function getCommonConfig(wco: WebpackConfigOptions): Promise<Config
{
loader: require.resolve('../../babel/webpack-loader'),
options: {
assumptions: {
// Use `setPublicClassFields: true` to avoid decrease bundle sizes
// when targetting ES2022+ with `useDefineForClassFields: true`.
// This is because ervery property of the class will otherwise be wrapped in a `_defineProperty`.
// This is not needed for TypeScript as TS itself will emit the right decleration of class properties.
setPublicClassFields: true,
},
cacheDirectory: (cache.enabled && path.join(cache.path, 'babel-webpack')) || false,
aot: buildOptions.aot,
optimize: buildOptions.buildOptimizer,
Expand Down