Skip to content

fix(@angular-devkit/build-angular): improve parsing of error messages #24776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Feb 24, 2023

Webpack errors can sometimes be several hundred of thousands of characters long as it may contain the entire bundle. This can cause a ReDoS. This change improves the way we parse and remove stack traces from error messages.

Closes #24771

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Feb 24, 2023
@alan-agius4 alan-agius4 requested a review from clydin February 24, 2023 12:45
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 24, 2023
@alan-agius4 alan-agius4 changed the title fix(@angular-devkit/build-angular): limit error message length to are passed to RegExp. fix(@angular-devkit/build-angular): improve parsing or error messages Feb 24, 2023
Webpack errors can sometimes be several hundred of thousands of characters long as it may contain the entire bundle. This can cause a ReDoS. This change improves the way we parse and remove stack traces from error messages.

Closes angular#24771
@alan-agius4 alan-agius4 changed the title fix(@angular-devkit/build-angular): improve parsing or error messages fix(@angular-devkit/build-angular): improve parsing of error messages Feb 24, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 24, 2023
@angular-robot angular-robot bot merged commit d4c4508 into angular:main Feb 24, 2023
@alan-agius4 alan-agius4 deleted the regexp-limit branch February 24, 2023 19:14
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Sealing" phase is stuck on
2 participants