-
Notifications
You must be signed in to change notification settings - Fork 12k
feature(config): config inline template & style in angular-cli.json #2457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, then I'll mrege.
@@ -71,7 +79,7 @@ module.exports = { | |||
|
|||
files: function() { | |||
var fileList = getFiles.call(this); | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please no end of line whitespaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed and re-pushed, thanks!
b1f95a8
to
ad0c232
Compare
@@ -71,7 +79,7 @@ module.exports = { | |||
|
|||
files: function() { | |||
var fileList = getFiles.call(this); | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No whitespace please.
ad0c232
to
1008b93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #2447