Skip to content

feature(config): config inline template & style in angular-cli.json #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2016

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Oct 1, 2016

Fixes #2447

Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, then I'll mrege.

@@ -71,7 +79,7 @@ module.exports = {

files: function() {
var fileList = getFiles.call(this);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no end of line whitespaces.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and re-pushed, thanks!

@Brocco Brocco force-pushed the issue2447-inline-settings branch 2 times, most recently from b1f95a8 to ad0c232 Compare October 1, 2016 19:29
@@ -71,7 +79,7 @@ module.exports = {

files: function() {
var fileList = getFiles.call(this);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No whitespace please.

@Brocco Brocco force-pushed the issue2447-inline-settings branch from ad0c232 to 1008b93 Compare October 1, 2016 19:46
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hansl hansl merged commit b224395 into angular:master Oct 1, 2016
@Brocco Brocco deleted the issue2447-inline-settings branch October 2, 2016 02:15
JJayet pushed a commit to JJayet/angular-cli that referenced this pull request Oct 2, 2016
deebloo pushed a commit to deebloo/angular-cli that referenced this pull request Oct 3, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Settings - allow config level values for inline style/template
3 participants