Skip to content

fix(@angular-devkit/build-angular): downlevel class private methods when targeting Safari <=v15 #24413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

alan-agius4
Copy link
Collaborator

This commits enables @babel/plugin-proposal-private-methods when targeting Safari <=v15 as this is needed to handle private class methods when using @babel/plugin-proposal-class-properties.

Closes #24411

…hen targeting Safari <=v15

This commits enables `@babel/plugin-proposal-private-methods` when targeting Safari <=v15 as this is needed to handle private class methods when using `@babel/plugin-proposal-class-properties`.

Closes angular#24411
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 12, 2022
@alan-agius4 alan-agius4 marked this pull request as ready for review December 12, 2022 09:00
@alan-agius4 alan-agius4 requested a review from clydin December 12, 2022 09:00
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 12, 2022
@angular-robot angular-robot bot merged commit 9737301 into angular:main Dec 12, 2022
@alan-agius4 alan-agius4 deleted the private-class-methods branch December 12, 2022 16:13
@dzonatan
Copy link
Contributor

When we can expect this patch to be released?

We're currently stuck with a broken application:
v15.0.0 - v15.0.2 has that issue with Safari <=15.
v15.0.3 doesn't build with private methods.

The only option is to temporarily revert to Angular v14 without this fix.

@alan-agius4
Copy link
Collaborator Author

This will be released later on today.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

class private methods are not enabled
3 participants