Skip to content

test: use common mockHome method #23687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

jbedard
Copy link
Contributor

@jbedard jbedard commented Aug 4, 2022

Primarily because one of them was using fs.mkdtemp instead of the util mktempd method which standardizes the tempdir logic. Using the common util method will allow bazel (#23074) to use the bazel tempdir instead of system tempdir

@jbedard jbedard requested a review from alan-agius4 August 4, 2022 03:44
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Aug 4, 2022
@dgp1130 dgp1130 merged commit d614a7e into angular:main Aug 4, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants