Skip to content

chore(generate): update routing files & add --routing to ng new #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Sep 27, 2016

No description provided.

const files = fs.readdirSync(pathToCheck)
.filter(fileName => !fileName.endsWith('routing.module.ts'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a scenario where someone has a single module called routing and we'll never find it, but tbh I don't think we should special-case it this far... when we refactor we'll handle it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to go away, the file name string matching is temporary.

@filipesilva filipesilva merged commit a9f9976 into angular:master Sep 27, 2016
@Brocco Brocco deleted the routing branch September 27, 2016 13:11
JJayet pushed a commit to JJayet/angular-cli that referenced this pull request Oct 2, 2016
deebloo pushed a commit to deebloo/angular-cli that referenced this pull request Oct 3, 2016
@oravecz
Copy link

oravecz commented Oct 8, 2016

ng serve currently results in errors in the console after running ng new --routing myapp

Error: Cannot match any routes: ''
    at resolvePromise (zone.js:429)
    at zone.js:406
    at ZoneDelegate.invoke (zone.js:203)
    at Object.onInvoke (ng_zone_impl.js:43)
    at ZoneDelegate.invoke (zone.js:202)
    at Zone.run (zone.js:96)
    at zone.js:462
    at ZoneDelegate.invokeTask (zone.js:236)
    at Object.onInvokeTask (ng_zone_impl.js:34)
    at ZoneDelegate.invokeTask (zone.js:235)

@Brocco
Copy link
Contributor Author

Brocco commented Oct 10, 2016

@oravecz include the options after the command + arguements. So in your example, run"

ng new myapp --routing

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants