Skip to content

fix(@angular-devkit/build-angular): fallback to use projectRoot when sourceRoot is missing during coverage #23592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

alan-agius4
Copy link
Collaborator


With this change we fallback to use the projectRoot when the sourceRoot is missing for files to be included in coverage.

Closes: #23591

…sourceRoot is missing during coverage

With this change we fallback to use the projectRoot when the sourceRoot is missing for files to be included in coverage.

Closes: angular#23591
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 18, 2022
@alan-agius4 alan-agius4 requested a review from clydin July 18, 2022 14:11
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jul 18, 2022
@alan-agius4 alan-agius4 marked this pull request as ready for review July 18, 2022 14:11
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 18, 2022
@clydin clydin merged commit d8cfe8b into angular:main Jul 18, 2022
@alan-agius4 alan-agius4 deleted the coverage-project-root branch July 18, 2022 16:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage is undefined if sourceRoot is not set
2 participants