Schematics class name validation #23485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
class-name-validation
branch
2 times, most recently
from
d271e42 to
8d8faec
Compare
clydin
requested changes
Jul 1, 2022
alan-agius4
force-pushed
the
class-name-validation
branch
from
8d8faec to
0fc7b05
Compare
alan-agius4
added
the
needs: discussion
…g without using a `.` `.` is not a valid character in ES6 class names. Prior to this change `foo.module` before used to be incorrectly classified to `Foo.Module` instead of `FooModule`. Closes angular#13824
With this change we prevent creating classes with invalid characters. Closes angular#12868
alan-agius4
force-pushed
the
class-name-validation
branch
from
0fc7b05 to
487f639
Compare
alan-agius4
removed
the
needs: discussion
clydin
approved these changes
Jul 21, 2022
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(@angular-devkit/core):
classifystring util should concat string without using a..is not a valid character in ES6 class names.Prior to this change
foo.modulebefore used to be incorrectly classified toFoo.Moduleinstead ofFooModule.Closes #13824
fix(@schematics/angular): prevent numbers from class names
With this change we prevent creating classes with invalid characters.
Closes #12868
Combined into a single PR as they are dependent on each other.