fix(@schematics/angular): use sourceRoot instead of src in universal schematic
#23463
+19
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sal schematic With this change we remove the usage of hard coded `src` directory and instead infer this from the `sourceRoot` project option. We also remove the `angularCompilerOptions.entryModule` property in the server tsconfig as this is no longer needed with Ivy. Closes angular#12104
alan-agius4
added
action: review
alan-agius4
force-pushed
the
universal-source-root
branch
from
aecbc07 to
ead77b6
Compare
clydin
approved these changes
Jun 29, 2022
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we remove the usage of harded
srcdirectory and instead infer this from thesourceRootproject option.We also remove the
angularCompilerOptions.entryModuleproperty in the server tsconfig as this is no longer needed with Ivy.Closes #12104