Skip to content

fix(@schematics/angular): remove vscode testing configurations for minimal workspaces #23371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2022
Merged

fix(@schematics/angular): remove vscode testing configurations for minimal workspaces #23371

merged 1 commit into from
Jun 15, 2022

Conversation

Julien-Marcou
Copy link
Contributor

Remove the ng test VS Code task and npm test VS Code launch configuration from the workspace when building minimal workspaces.

Fixes #23360

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

…inimal` workspaces

Remove the `ng test` VS Code task and `npm test` VS Code launch configuration from the workspace
when building minimal workspaces.

Fixes #23360
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jun 15, 2022
@angular-robot angular-robot bot requested a review from alan-agius4 June 15, 2022 07:10
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 15, 2022
@alan-agius4 alan-agius4 merged commit 7cbbf2f into angular:main Jun 15, 2022
@Julien-Marcou Julien-Marcou deleted the fix-minimal-vscode-configation branch June 15, 2022 09:05
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating new application without testing framework does not generate correct .vscode files
2 participants