Skip to content

fix(@angular/cli): ensure full process exit with older local CLI versions #23298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

clydin
Copy link
Member

@clydin clydin commented Jun 7, 2022

Angular CLI versions prior to v14 may not exit correctly if not forcibly exited
via process.exit. When the local CLI version is less than v14, the CLI will now
use process.exit to ensure the process exits with these older CLI versions.

@clydin clydin added the target: patch This PR is targeted for the next patch release label Jun 7, 2022
@clydin clydin force-pushed the cli-v14-exit-interop branch from 741c29c to 8774cf7 Compare June 7, 2022 14:39
@clydin clydin marked this pull request as ready for review June 7, 2022 14:39
@clydin clydin requested a review from alan-agius4 June 7, 2022 15:18
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 7, 2022
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: can you update the commit to close #23289?

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 7, 2022
…ions

Angular CLI versions prior to v14 may not exit correctly if not forcibly exited
via `process.exit`. When the local CLI version is less than v14, the CLI will now
use `process.exit` to ensure the process exits with these older CLI versions.

Fixes angular#23289
@clydin clydin force-pushed the cli-v14-exit-interop branch from 8774cf7 to b0db500 Compare June 7, 2022 16:00
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 7, 2022
@clydin clydin merged commit d788263 into angular:main Jun 7, 2022
@clydin clydin deleted the cli-v14-exit-interop branch June 7, 2022 20:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular CLI 14: running ng test --watch=false on Angular 13 or 12 project does not end process when complete
2 participants