Skip to content

fix(@angular-devkit/build-angular): replace dev-server socket path from /ws to /ng-cli-ws #23266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2022
Merged

fix(@angular-devkit/build-angular): replace dev-server socket path from /ws to /ng-cli-ws #23266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/angular_devkit/build_angular/src/builders/dev-server/specs/live-reload_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ function createProxy(target: string, secure: boolean, ws = true): ProxyInstance

async function goToPageAndWaitForWS(page: Page, url: string): Promise<void> {
const baseUrl = url.replace(/^http/, 'ws');
const socksRequest = baseUrl[baseUrl.length - 1] === '/' ? `${baseUrl}ws` : `${baseUrl}/ws`;
const socksRequest =
baseUrl[baseUrl.length - 1] === '/' ? `${baseUrl}ng-cli-ws` : `${baseUrl}/ng-cli-ws`;
// Create a Chrome dev tools session so that we can capturing websocket request.
// https://github.com/puppeteer/puppeteer/issues/2974

Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_angular/src/webpack/configs/dev-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ function getWebSocketSettings(
};
}

const webSocketPath = posix.join(servePath, 'ws');
const webSocketPath = posix.join(servePath, 'ng-cli-ws');

return {
webSocketServer: {
Expand Down